Remove a few ECMA_TRY_CATCH macro usages #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
requested changes
Mar 20, 2018
jerry-core/vm/opcodes.c
Outdated
| ECMA_FINALIZE (check_coercible_ret); | ||
| } | ||
| ecma_value_t delete_op_ret = ecma_op_object_delete (obj_p, name_string_p, is_strict); | ||
| JERRY_ASSERT (ecma_is_value_boolean(delete_op_ret) || (is_strict == true && ECMA_IS_VALUE_ERROR (delete_op_ret))); |
Contributor
There was a problem hiding this comment.
missing space: ecma_is_value_boolean (delete_op_ret)
| ecma_string_t *left_value_prop_name_p = ecma_get_string_from_value (str_left_value); | ||
| ecma_object_t *right_value_obj_p = ecma_get_object_from_value (right_value); | ||
| ecma_value_t left_string_value = ecma_op_to_string (left_value); | ||
| if (ECMA_IS_VALUE_ERROR(left_string_value)) |
Contributor
There was a problem hiding this comment.
missing space: ECMA_IS_VALUE_ERROR (left_string_value)
By removing the ECMA_TRY_CATCH macros at these places ~200 bytes of .text is saved on rpi2. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
galpeter
force-pushed
the
ecmatrycatch-rem1
branch
from
ed0c80f to
ae7dd81
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the ECMA_TRY_CATCH macros at these
places ~200 bytes of .text is saved on rpi2.